Respect fileCkeckExists option, even when we have a host #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zerkalica any chance you can have a look this? :) |
|
Main goal of this manipulations with getSourceFile - reduce file system queries. Does host.fileExists cache it? |
Yes, see here: This is used unless the user disables caching. |
zerkalica
pushed a commit
that referenced
this pull request
Apr 4, 2020
|
Try 1.7.16, i remove getSourceFile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in case you're using this transformer with
ts.transpileModule. In which case,isolatedModules=true.TypeScript specifies a one-off function that only returns the source for the module we're currently transpiling. This means that
getSourceFilewill only returntruefor the module being transpiled. This can be worked around by settingfileCkeckExiststo true, but this option is not respected when there is a program and therefor a host.A practical example where this problematic is
ts-jestwith theisolatedModulesoption set totrue. See: https://github.com/kulshekhar/ts-jest/blob/v25.2.0/src/compiler.ts#L98 In this case,ts-jestusests.transpileModuleand without thefileCkeckExistsoption properly working, transformation won't happen.