Add warning when API resolves without the request being finished #9999

ijjk · 2020-01-09T00:24:35Z

This checks to make sure a response was sent after an API call is resolved to make sure API routes aren't left stalled. Also, added a test for this behavior

ijjk · 2020-01-09T00:30:22Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	11.2s	11.4s	⚠️ +240ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +386 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	11.6s	11.7s	⚠️ +117ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +386 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_error.js gzip	77.8 kB	77.8 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	✓
link.js gzip	80.4 kB	80.4 kB	✓
routerDirect.js gzip	78 kB	78 kB	✓
withRouter.js gzip	78.1 kB	78.1 kB	✓
Overall change	393 kB	393 kB	✓

Commit: afe410e

Timer

This feels very breaking, especially for callback based code. It'd force people to use promises (via async await).

ijjk · 2020-01-09T04:11:22Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	13.3s	13.3s	-23ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +502 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	13.4s	13.6s	⚠️ +181ms
nodeModulesSize	48.9 MB	48.9 MB	⚠️ +502 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_error.js gzip	77.8 kB	77.8 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	✓
link.js gzip	80.4 kB	80.4 kB	✓
routerDirect.js gzip	78 kB	78 kB	✓
withRouter.js gzip	78.1 kB	78.1 kB	✓
Overall change	393 kB	393 kB	✓

Commit: 15b088e

ijjk · 2020-01-09T04:12:50Z

Updated to only log a warning in development instead of throwing an error since that would be breaking

Janpot · 2020-01-09T09:45:13Z

This feels very breaking, especially for callback based code. It'd force people to use promises.

Maybe it can only warn/fail if the resolver returns something different than undefined? Or only when it returns a Promise?

packages/next/next-server/server/api-utils.ts

Timer

LGTM now that it's a warning. Let's see if we get user feedback.

ijjk · 2020-01-10T15:48:54Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	12.8s	12.7s	-147ms
nodeModulesSize	49 MB	49 MB	⚠️ +504 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	13.3s	13.3s	⚠️ +66ms
nodeModulesSize	49 MB	49 MB	⚠️ +504 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_error.js gzip	77.8 kB	77.8 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	✓
link.js gzip	80.4 kB	80.4 kB	✓
routerDirect.js gzip	78.1 kB	78.1 kB	✓
withRouter.js gzip	78.1 kB	78.1 kB	✓
Overall change	393 kB	393 kB	✓

Commit: fe758cb

ijjk · 2020-01-10T15:52:16Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	14.4s	14.4s	-2ms
nodeModulesSize	49 MB	49 MB	⚠️ +504 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
buildDuration	15.1s	15s	-91ms
nodeModulesSize	49 MB	49 MB	⚠️ +504 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js fix/api-not-ending	Change
_error.js gzip	77.8 kB	77.8 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	✓
link.js gzip	80.4 kB	80.4 kB	✓
routerDirect.js gzip	78.1 kB	78.1 kB	✓
withRouter.js gzip	78.1 kB	78.1 kB	✓
Overall change	393 kB	393 kB	✓

Commit: 58a05e0

klarstrup · 2020-02-04T16:58:43Z

Annoyed that I cannot silence this warning when I can confirm that things are working perfectly

Add error when API resolves without the request being finished

afe410e

ijjk requested review from lfades, Timer and timneutkens as code owners January 9, 2020 00:24

ijjk added this to the 9.2.0 milestone Jan 9, 2020

Timer requested changes Jan 9, 2020

View reviewed changes

Update to only show warning in development instead

15b088e

ijjk requested a review from Timer January 9, 2020 04:12

ijjk changed the title ~~Add error when API resolves without the request being finished~~ Add warning when API resolves without the request being finished Jan 9, 2020

Timer reviewed Jan 10, 2020

View reviewed changes

packages/next/next-server/server/api-utils.ts Outdated Show resolved Hide resolved

Update packages/next/next-server/server/api-utils.ts

fe758cb

Timer approved these changes Jan 10, 2020

View reviewed changes

Timer added ready to land labels Jan 10, 2020

Merge branch 'canary' into fix/api-not-ending

58a05e0

Timer merged commit 14ca20d into vercel:canary Jan 10, 2020

Timer deleted the fix/api-not-ending branch January 10, 2020 15:56

hoangvvo mentioned this pull request Jan 31, 2020

[Question] API resolved without sending a response for /api/sections/publication, this may result in a stalled requests. hoangvvo/nextjs-mongodb-app#50

Closed

hoangvvo mentioned this pull request Feb 11, 2020

"API resolved without sending a response" appearing on every route despite the API routes working fine. hoangvvo/next-connect#30

Closed

snyk-bot mentioned this pull request Feb 11, 2020

[Snyk] Upgrade next from 9.1.5 to 9.2.0 ndom91/newtelco-next-maintenance-mgmt#16

Merged

hoangvvo mentioned this pull request Feb 17, 2020

next-session showing "API resolved without sending a response" log message every request hoangvvo/next-session#73

Closed

jordymeow mentioned this pull request Mar 10, 2020

API resolved without sending a response (another one) #10777

Closed

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warning when API resolves without the request being finished #9999

Add warning when API resolves without the request being finished #9999

ijjk commented Jan 9, 2020

ijjk commented Jan 9, 2020

Timer left a comment •

edited

Loading

ijjk commented Jan 9, 2020

ijjk commented Jan 9, 2020

Janpot commented Jan 9, 2020 •

edited

Loading

Timer left a comment

ijjk commented Jan 10, 2020

ijjk commented Jan 10, 2020

klarstrup commented Feb 4, 2020

Add warning when API resolves without the request being finished #9999

Add warning when API resolves without the request being finished #9999

Conversation

ijjk commented Jan 9, 2020

ijjk commented Jan 9, 2020

Stats from current PR

Timer left a comment • edited Loading

Choose a reason for hiding this comment

ijjk commented Jan 9, 2020

Stats from current PR

ijjk commented Jan 9, 2020

Janpot commented Jan 9, 2020 • edited Loading

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Jan 10, 2020

Stats from current PR

ijjk commented Jan 10, 2020

Stats from current PR

klarstrup commented Feb 4, 2020

Timer left a comment •

edited

Loading

Janpot commented Jan 9, 2020 •

edited

Loading