-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add D2 layout engine option #1570
Merged
ggrossetie
merged 5 commits into
yuzutech:main
from
felixvanoost:add-d2-layout-engine-option
Aug 11, 2023
Merged
Add D2 layout engine option #1570
ggrossetie
merged 5 commits into
yuzutech:main
from
felixvanoost:add-d2-layout-engine-option
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks good to me. |
@ggrossetie I made these changes while travelling and haven't had time to test them yet. If someone wants to test that the |
Looking forward. 👍 |
felixvanoost
force-pushed
the
add-d2-layout-engine-option
branch
from
August 11, 2023 18:47
ce9f796
to
3147ecc
Compare
felixvanoost
changed the title
WIP: Add D2 layout engine option
Add D2 layout engine option
Aug 11, 2023
@ggrossetie I finally had time to test this; results are in the PR description above. It's working! |
That's quite nice 😍 |
ggrossetie
reviewed
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for alternate D2 layout engines (see documentation). Currently this includes both the default layout engine,
dagre
, and an open-source third-party alternative,ELK
.The
TALA
engine is not supported because it is proprietary (non-free) and closed-source.Output with no layout specified (
dagre
is used by default):Output with
layout=elk
:Closes #1557