Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #1480 Use PlantUML as native image #1515

Merged

Conversation

ggrossetie
Copy link
Member

@ggrossetie ggrossetie commented Apr 16, 2023

TODO

  • Implement PNG/base64 (maybe we should add it on all diagram librairies which support PNG)
  • Enable Structurizr and C4 PlantUML tests again

Known issues

  • help themes won't list all the themes

@ggrossetie ggrossetie force-pushed the issues-1480-plantuml-native-image branch from d2be4d5 to 6476077 Compare April 22, 2023 14:10
@ggrossetie
Copy link
Member Author

Implement PNG/base64 (maybe we should add it on all diagram librairies which support PNG)

I'm actually not quite sure about this feature. We might want to implement it as a post-processor step since technically we could produce base64 output from PNG, or JPEG or even SVG (and/or PDF?).
In my opinion, it does not really make sense for utxt or txt output but who knows...

Anyway, I will restore this feature as-is for now.

@ggrossetie ggrossetie force-pushed the issues-1480-plantuml-native-image branch from 1564e5d to 3c595c7 Compare April 23, 2023 14:38
@ggrossetie ggrossetie merged commit c3f18b1 into yuzutech:main Apr 23, 2023
@ggrossetie ggrossetie deleted the issues-1480-plantuml-native-image branch April 23, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call PlantUML as a native image rather than a Java library
1 participant