Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for chrome #16

Open
ylecuyer opened this issue Jun 6, 2018 · 3 comments
Open

Add support for chrome #16

ylecuyer opened this issue Jun 6, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ylecuyer
Copy link
Owner

ylecuyer commented Jun 6, 2018

Although the dynamic theme API isn't yet available for chrome, we could insert an element in the page like a ribbon on top of the pages with the color
@ylecuyer ylecuyer added enhancement New feature or request good first issue Good for newcomers labels Jun 6, 2018
@ylecuyer
Copy link
Owner Author

This repo is a proof of concept of envify running inside chrome.

It will have to be merged into this repo when stable.

@Smile4ever would you like to try it ?

@Smile4ever
Copy link

@ylecuyer I tested it, looks good. I had some ideas to improve it for Chrome and I have implemented these features locally. If time allows, I will submit a pull request this evening.

@Smile4ever
Copy link

See ylecuyer/envify-chrome#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Smile4ever @ylecuyer