-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the callback
option
#158
Remove the callback
option
#158
Conversation
You are not deprecating it, you are removing it. |
And you missed this point:
|
@sindresorhus The previous code only does
We already have the |
Yes, but I think it needs a better name. Maybe |
This method is doing something about get some information. Maybe we could name this method |
I don't like the name |
@sindresorhus Updated |
Can you also fix the merge conflict? |
Sure. |
Just deprecate the
callback
option as #85 (comment) mentioned.It's a breaking change.