Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-unsafe rule #1830

Closed
sergei-startsev opened this issue Jun 17, 2018 · 1 comment
Closed

Add no-unsafe rule #1830

sergei-startsev opened this issue Jun 17, 2018 · 1 comment
Labels
accepted help wanted new rule

Comments

@sergei-startsev
Copy link
Contributor

Certain legacy lifecycle methods are unsafe for use in async React applications and cause warnings in strict mode:

  • UNSAFE_componentWillMount
  • UNSAFE_componentWillReceiveProps
  • UNSAFE_componentWillUpdate.

These also happen to be the lifecycles that cause the most confusion within the React community. At the same time there're no deprecation warnings regarding using UNSAFE_ methods and it will still be possible to use them in React 17.

The rule prevents usage of of UNSAFE_ lifecycle methods. See discussion details #1750 (comment).
@sergei-startsev sergei-startsev mentioned this issue Jun 17, 2018
Merged
@sergei-startsev
Copy link
Contributor Author

The rule has been merged.

@dependencies dependencies bot mentioned this issue Jul 9, 2018
Closed
@dependencies dependencies bot mentioned this issue Aug 1, 2018
Open
This was referenced Sep 22, 2018
Open
Closed
Closed
Open
Open
Closed
Closed
Closed
Open
Open
Open
Merged
Closed
Closed
Open
Merged
Open
Closed
Closed
Open
Open
This was referenced Oct 27, 2018
Open
Merged
@dependencies dependencies bot mentioned this issue Nov 1, 2018
Closed
This was referenced Nov 4, 2018
Closed
Merged
Closed
This was referenced Nov 23, 2018
Open
Merged
@renovate renovate bot mentioned this issue Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this issue Dec 19, 2018
Closed
1 task
@renovate-bot renovate-bot mentioned this issue Dec 19, 2018
Merged
1 task
This was referenced Dec 21, 2018
Open
Merged
Merged
Closed
Merged
Closed
This was referenced Jan 2, 2019
Merged
Closed
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted help wanted new rule
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @sergei-startsev