Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pad powerline glyphs and use ideographic text baseline #3279

Merged
merged 5 commits into from
Apr 2, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 1, 2021

Fixes #3278
Fixes #3281

Webgl before:

image

Webgl after:

image

Canvas before:

image

Canvas after:

image

@Tyriar Tyriar added this to the 4.12.0 milestone Apr 1, 2021
@Tyriar Tyriar self-assigned this Apr 1, 2021
Tyriar added 4 commits April 1, 2021 16:55
This seems to correctly center the glyphs within the cell, making powerline
fonts appear perfectly aligned.

Fixes xtermjs#3281
@Tyriar Tyriar changed the title Don't pad powerline glyphs Don't pad powerline glyphs and use ideographic text baseline Apr 2, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Apr 2, 2021

Created https://github.com/xtermjs/xterm.js/wiki/Powerline-fonts for future reference on printing them out without changing your prompt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webgl and canvas renderers are not correctly aligned Powerline glyphs don't render nicely in the webgl addon
1 participant