Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New developments in weather forecasting #183

Open
witchof0x20 opened this issue Jun 21, 2024 · 1 comment
Open

New developments in weather forecasting #183

witchof0x20 opened this issue Jun 21, 2024 · 1 comment

Comments

@witchof0x20
Copy link
Contributor

witchof0x20 commented Jun 21, 2024

This wonderful thread details an inconsistency in the WeatherRate sheet: all rows have rates that sum to 100, except Empyreum (and null rows). This causes incorrect weather prediction for the zone. The author found that using the sum of rates rather than a flat 100 matches up with in-game behavior.

I don't know C# very well, but I believe the fix would be to update this line to something like

return (int)(step2 % _WeatherRates.sum());

I think this also means the function should no longer be static.

@witchof0x20
Copy link
Contributor Author

Cross-referencing this document, which would also be revised by this change https://github.com/xivapi/ffxiv-datamining/blob/master/docs/Weather.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant