Added support for specifying the local address or port to SshConnection. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
XebiaLabs » overthere #217 SUCCESS |
|
Hi Bastiaan, Just 2 more comments left ;) Can you integrate them in this PR, then I'll merge it. |
|
@hierynomus : these properties are not inherently SSH specific, but could be used for e.g TelnetConnections as. well. That's why they are under Common Connection Options. |
|
Good enough explanation to merge the PR as is ? ;-) |
|
AS they're not currently being used for anything else, and we might not do this for a long time. Just also discussed with @vpartington to move them to SSH. |
|
XebiaLabs » overthere #219 SUCCESS |
hierynomus
added a commit
that referenced
this pull request
Oct 13, 2014
…ress-option Added support for specifying the local address or port to SshConnection.
|
Done! Thx! |
|
@hierynomus Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to bind to a specific local host address and local port to SshConnection via options 'localAddress' and 'localPort', like OpenSSHs' '-b' parameter.
Binding to a specific local address or port may be necessary for compliance with network policies (e.g. routing or firewall settings).
replaces PR bastiaanb:feature-SshConnection-bindAddress-option