Guppyscreen todo list

[consp]

List of thing to do to get it properly working, suggestion are welcome.

• create buildroot package
• create mainsail prompt items (backportable)
• fix blanking (disable backlight)
• enable changing of brightness
• make evdev select the correct event (backportable)
• test all commands (level, shaker etc) shaker might crash klipper
• fix invisible wifi password input field (backportable)
• enable deletion of wifi items (backportable)
• make sure wpa autoconnects
• include or change code to use/not use the custom macos (e.g. input shaper, not a macro issue but related to system load)
• disable spoolman
• disable update guppy
• provide proper config
• Add 'restart' / 'restart_firmware' prompt (backportable)
• Add 'save_config' prompt (backportable)

changes so far: https://github.com/consp/guppyscreen/tree/flashforge_ad5m

(backportable) -> items can be added to main branch without too much issues if the maintainer whiches. Other items are platform specific.

[ballaswag]

The custom input shaper is almost a one to one copy of that’s in klipper. It adds a structure json return for easier consumption inside Guppy Screen. It also enables displaying of the png in Guppy Screen.

[consp]

Will probably write a pass-though macro, shouldn't be too much of a problem, that way the main codebase can remain the same.

Thanks for the heads up, will save me quite some time looking into the changes :)

[consp]

Added BR2_PACKAGE_GUPPYSCREEN to the buildroot as well, needs some makefile patches since every makefile thinks it's in control (and isn't). See xblax/flashforge_adm5_buildroot_chroot@master...feature/buildsystem

[xblax]

Ok, great! I will move that package into the main repo together with the other custom buildroot packages.
I have already started to work on that, but need to clean this up a bit.

[consp]

Sounds good, I'm not going to mess with it too much right now, getting the makefiles to work was quite an adventure enough 😅

I did push some changes sincve it needs the libevdev dependency otherwise the build will fail due to missing headers.

[consp]

It also needs a change to the post build script as it now deploys the guppyscreen in printer_software and that is rm -rf'd in that file (pushed to feature branch).

[consp]

If the wifi changes get accepted I'm probably going to make it a patch and pull from the original repo, that way it is easier to stay up to date and simply patch everything.

[consp]

on wpa auto connecting ... looks like it does, but it takes quite a while. At least it looks to be that way. If anyone has more ideas about this I'd like to know.

[ballaswag]

Maybe there a way to force some client to acquire dhcp lease quicker? Maybe dhclient?

[consp]

Could be, or a race condition where the dhcp client already sends a request before the link is ready. Wpa sometimes also "waits" a while for some reason before attempting to connect. Haven't looked much further though.

[xblax]

@consp
I have integrated your Guppyscreen branch while working on the buildsystem (see #32). It's still on the buildsystem branch, but will then push it to master soon.

Build worked basically on first attempt for me and memory usage really looks much better. Great work!

Should we plan to already include Guppyscreen build in the next release? (even if not, we can alreadyl integrate the changes on master).

[consp]

Probably yes, I already updated a bit which should be present since it pulls the branch not the commit. Few minor changes to do but those are not critical. I do have some issues with wifi only sometimes: it gets an ip, connects but does not respond to pings and not to any tcp/ip traffic. It does respond to arp requests though.

[consp]

Checklist for panel tests and known issues:

Test checklist

• homing (including moving)
• load/unload (note: extrude/retract wait for temperature so be patient)
• fans
• led
• print
• printer settings
  • mesh -> note: uses BED_MESH_CALIBRATE
  • finetune
  • input shaper -> crashes first time same as klipperscreen due to eboard timeout, second time it works. Looks like numpy hogs too much memory on first load (maybe load it ahead of time?)
  • belts
  • limits
  • tmc autotune (disabled)
  • tmc metrics (does nothing as it's not enabled)
• settings
  • wifi
  • system settings
  • restart guppy
  • restart klipper
  • restart firmware

Known issues

• some menu's might work a bit different from klipperscreen, keep this in mind
• Input shaper will stop the first time due to excessive memory consumption triggering an eboard timeout
• FIRMWARE_RESET message might not show up after input shaper error, you must use fluidd or mainsail in that case.
• RESET message might not show up after input shaper error, you must use fluidd or mainsail in that case.
• "Printer initializing" message might be stuck on screen for a while. (infinity is also a while, if you have this, please let it be known)
• Pressing the power button will not wake up the screen
• Wifi will only work when ethernet is connected (yes, it's broken) looks like it works now

[ballaswag]

Tmc metrics work if you include the last 3 klippy modules here https://github.com/ballaswag/guppyscreen/tree/main/k1/k1_mods and enable them in printer.cfg.

Tmc autotune, I feel like it's somewhere a hit and miss. I didn't enable and distribute for the k1 because the tmc autotune module needed some small refactor to work on the old k1 klipper.

If this is a thing you want for your printer and it's running newer klipper, you can just install this klippy module and it should enable the button.

https://github.com/andrewmcgr/klipper_tmc_autotune

[consp]

running newer klipper

Unfortunately that's a bit of a bind, since flashforge decided in their wisdom that GPL does not include the makefiles which have the custom configs for the STM32 clone chip they used, so for now it's v0.11 or bust (which is what is shipped).

[consp]

Tmc autotune, I feel like it's somewhere a hit and miss. I didn't enable and distribute for the k1 because the tmc autotune module needed some small refactor to work on the old k1 klipper.

I think I'll disable them for now as it's a 'advanced user' thing and not really needed for normal operation.

[consp]

Tmc metrics work if you include the last 3 klippy modules here https://github.com/ballaswag/guppyscreen/tree/main/k1/k1_mods and enable them in printer.cfg.

Good point! I'll have a look one the new version of the mod is released.

[consp]

@ballaswag fyi, preloading numpy at start of klipper allows the input shaper to work first time around with guppyscreen (at least in my fresh-from-boot-inputshaper-test)

edit: well ... one out of three times

[b-fitzpatrick]

I've been trying out the Guppyscreen version. Most everything is working great. @consp, looking at your fork of Guppyscreen, it appears that you added support for response actions (but not button groups, yet). I am trying to use a prompt as just a notification with only an "OK" button. That seems to work if I only interact with Guppyscreen. The prompt shows up on screen in Fluidd, and it dismisses both places if OK is tapped on screen. If I dismiss via Fluidd, it hangs Guppyscreen. First, the button text changes to gibberish, and when I tap it, it hangs.

Is there a better way to show a notification? My immediate usage is for filament runout.

[consp]

For those interested in the attachment the a guppyscreen file with the latest changes, no warenty whatsoever, replace /root/printer_software/guppyscreen/guppyscreen with it and restart guppyscreen or reboot (rename, because github).

Caution

If you do not know how to do the above this is not meant for you. Bugs may happen.

I'm trying it out now, let's see how it goes.

guppyscreen.txt

[b-fitzpatrick]

@consp has it been working well for you? Any fixes coming? If this is still the latest and greatest, I'll give it a try.

[KaruroChori]

I used it to handle some macros to switch material mid print and it works well for me.

[consp]

So far it works fine for me, but I mainly use it now for shutting down now (for the "shutdown" prompt).

No errors yet and I've abused it quite a bit. Haven't checked for memory leaks but it's also mainlined now so if those occur it will definitely show up somewhere.

Sidenote: The spelling mistake in my test prompt is starting to annoy me ... 🤦‍♂️

[b-fitzpatrick]

So far, so good

[b-fitzpatrick]

This isn’t new, but in case you haven’t noticed, it appears there’s some sort of status message that’s mostly off-screen. It shows up on the home screen when a print job is paused.

[consp]

Ah yes, probably due to the change in location of the temperature numers, which needed to move a bit if you want the pressure and air sensors in there as well.

Should be fixable, I'll have a look.

[ballaswag]

Ah yes, probably due to the change in location of the temperature numers, which needed to move a bit if you want the pressure and air sensors in there as well.

Should be fixable, I'll have a look.

Maybe just make that container scrollable , then more sensors can be displayed.

[consp]

Maybe just make that container scrollable , then more sensors can be displayed.

That is an option but it looks horrible as the last 20% of the bottom one is what is cut off and there is no obvious way to display it's scrollable without a grey bar in the middle of the screen.