[Xamarin.Android.Build.Tasks] Handle Empty R.txt file. #7133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Xamarin.Android.Build.Tasks/Utilities/ManagedResourceParser.cs
Outdated
Show resolved
Hide resolved
Fixes https://i.azdo.io/1439405 The ManagedResourceParser was not handling the case where we do not get four items per line. As a result it would crash with the following error. ``` System.IndexOutOfRangeException: Index was outside of bounds of the array. as Xamarin.And.Tasks.ManagedResourceParser.ProcessRtxtFile (System.String file) ``` If we do not get the expected four items from the line in the file we should ignore that line. A unit test has been added to check that the task does not fail when this happens.
jonathanpeppers
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
I think the test failures are unrelated:
06-29 10:43:52.573 4924 4924 I XALINKERTESTS: [FAIL] HttpClientTest.Post FAILED: System.Net.Http.HttpRequestException: Response status code does not indicate success: 504 (Gateway Time-out).
06-29 10:43:52.573 4924 4924 I XALINKERTESTS: at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode () [0x00040] in <8ef0bbcec78b495f8aa1c8e4c4c398b3>:0
06-29 10:43:52.573 4924 4924 I XALINKERTESTS: at HttpClientTest.Post () [0x0002f] in <80b7ca95626f470f8b58e6d11ea567ea>:0
error ANDZA0000: Unable to open 'obj/Debug/android/bin/com.xamarin.applicationjavaclassproperties.apk' as zip archive
jonpryor
reviewed
Jun 29, 2022
...in.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/ManagedResourceParserTests.cs
Outdated
Show resolved
Hide resolved
jonpryor
reviewed
Jun 29, 2022
src/Xamarin.Android.Build.Tasks/Utilities/ManagedResourceParser.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://i.azdo.io/1439405
The ManagedResourceParser was not handling the case where we do not
get four items per line. As a result it would crash with the following
error.
If we do not get the expected four items from the line in the file we
should ignore that line. A unit test has been added to check that the
task does not fail when this happens.