[One .NET] add win-arm64 support to the workload #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1544836 I'll manually test this when the build is done. It might be worth writing a doc on testing on `win-arm64`.
|
This magically worked first try, so I think we should just merge this.
I will write a how-to doc, but I need to ask the .NET SDK a couple questions, if we can make it easier. |
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1544836
Context: https://github.com/xamarin/LibZipSharp/commit/33f5b0184fb007f9c02fecf82036ab469afa050b
xamarin/LibZipSharp@33f5b018 added win-arm64 builds to the
[Xamarin.LibZipSharp][0] NuGet package as
`runtimes\win-arm64\native\libZipSharpNative.dll`.
Copy `runtimes\win-arm64\native\libZipSharpNative.dll` into
`$(MSBuildSrcDir)\arm64\libZipSharpNative.dll` so that it can be used
by `Xamarin.Android.Build.Tasks.dll`.
Update the `Microsoft.Android.Sdk` and `Microsoft.Android.Sdk.NET6`
packs to list `win-arm64` as a supported platform.
[0]: https://www.nuget.org/packages/Xamarin.LibZipSharp/ |
simonrozsival
pushed a commit
to simonrozsival/xamarin-android
that referenced
this pull request
May 31, 2022
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1544836 Context: dotnet/android-libzipsharp@33f5b01 dotnet/android-libzipsharp@33f5b018 added win-arm64 builds to the [Xamarin.LibZipSharp][0] NuGet package as `runtimes\win-arm64\native\libZipSharpNative.dll`. Copy `runtimes\win-arm64\native\libZipSharpNative.dll` into `$(MSBuildSrcDir)\arm64\libZipSharpNative.dll` so that it can be used by `Xamarin.Android.Build.Tasks.dll`. Update the `Microsoft.Android.Sdk` and `Microsoft.Android.Sdk.NET6` packs to list `win-arm64` as a supported platform. [0]: https://www.nuget.org/packages/Xamarin.LibZipSharp/
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
May 31, 2022
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1544836 Context: dotnet/android-libzipsharp@33f5b01 dotnet/android-libzipsharp@33f5b018 added win-arm64 builds to the [Xamarin.LibZipSharp][0] NuGet package as `runtimes\win-arm64\native\libZipSharpNative.dll`. Copy `runtimes\win-arm64\native\libZipSharpNative.dll` into `$(MSBuildSrcDir)\arm64\libZipSharpNative.dll` so that it can be used by `Xamarin.Android.Build.Tasks.dll`. Update the `Microsoft.Android.Sdk` and `Microsoft.Android.Sdk.NET6` packs to list `win-arm64` as a supported platform. [0]: https://www.nuget.org/packages/Xamarin.LibZipSharp/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1544836
I'll manually test this when the build is done. It might be worth writing a doc on testing on
win-arm64.