Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License is unclear #28

Open
mdeverdelhan opened this issue Mar 21, 2015 · 11 comments · Fixed by #98
Open

License is unclear #28

mdeverdelhan opened this issue Mar 21, 2015 · 11 comments · Fixed by #98

Comments

@mdeverdelhan
Copy link
Contributor

The LICENSE.txt file contains a LGPL 2.1 while the headers of source files are Apache 2.0 compliant. Exactly under which license the plugin is released?

@wvengen
Copy link
Owner

wvengen commented Mar 21, 2015

Good point. I see that the original sources have this as well.
The file LICENSE.txt is from 2007, while the updated headers have a commit from 2008 mentioning "Updated headers: Licensed under the Apache License". I guess Apache it is.

Anyone care to check with pyx4me people?

@cmorty
Copy link
Collaborator

cmorty commented Mar 22, 2015

@wvengen I'll do.

@skarzhevskyy
Copy link

The LGPL originally popup up because progurad was linked in code(in pyx4me code) at Compile Time. I believe in last version we have removed this linking and progurad is called using reflection.
Please be aware of this part! When you maintaining the code!

As to pyx4me code it was intended as Apache License.
I was unclear for me how to deal with dependencies in maven.
So because of dependency on "proguard" runtime that assume compile the LICENSE.txt (LGPL) was not removed.

If you find a proper guides on how do deal with this you can remove the LICENSE.txt (LGPL) from proguard-maven-plugin code.

@cmorty
Copy link
Collaborator

cmorty commented Jan 11, 2017

@wvengen, @skarzhevskyy If I get this right, we should remove the LICENSE.txt, or rather replace it with the Apache license, and change the license of the github-project to Apache. Right?

@wvengen
Copy link
Owner

wvengen commented Jan 11, 2017

Did anyone check for that ProGuard is indeed called using reflection (or fork)?
If that's the case, we can remove LICENSE.txt indeed and specify the license as Apache.

@skarzhevskyy
Copy link

As I said I have no objection for changing LICENSE.

@wvengen
Copy link
Owner

wvengen commented Jan 13, 2017

Check, let's do so! Thanks everyone for getting clarity on this.

@Lonzak
Copy link

Lonzak commented Feb 13, 2018

The License on the main page ist still LGPL 2.1 (Top right corner)
https://github.com/wvengen/proguard-maven-plugin

And I just saw that the license.txt is also still LGPL. @wvengen Didn't you want to change that?

lasselindqvist referenced this issue in lasselindqvist/proguard-maven-plugin Jul 13, 2019
License "change" based on discussion in #28
@maloewe-ona
Copy link

A few questions:

  • Should the LICENSE.txt file containing the old LGPL license be deleted then? Because some tooling, such as the GitHub UI, still considers it:
    GitHub UI license
  • Should the pom.xml be adjusted as well?
    <license>
    <name>GNU Lesser General Public License (LGPL)</name>
    <url>https://www.gnu.org/licenses/lgpl.html</url>
    </license>

@lasselindqvist
Copy link
Collaborator

@maloewe-ona can you provide a pull request for updating that? If not, I will do it when I have time.

@maloewe-ona
Copy link

maloewe-ona commented Aug 17, 2023

@lasselindqvist, no sorry I cannot provide a pull request for this.

Though as small hint (in case this is useful); the Maven POM reference recommends that the <name> should be an SPDX identifier, so for Apache 2.0, it should probably be <name>Apache-2.0</name>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants