Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemfile.lock? #206

Closed
firefart opened this issue Jun 2, 2013 · 4 comments
Closed

Add Gemfile.lock? #206

firefart opened this issue Jun 2, 2013 · 4 comments

Comments

@firefart
Copy link
Contributor

firefart commented Jun 2, 2013

Just reading through the internet and came up with one question:
Should we add the Gemfile.lock to the repository?
All articles say, you should commit Gemfile.lock except you are developing a gem.
What do you think? Should we include the Gemfile.lock?

http://gembundler.com/v1.3/rationale.html#checking-your-code-into-version-control
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
http://stackoverflow.com/a/4151540

@erwanlr
Copy link
Member

erwanlr commented Jun 3, 2013

I really don't know :x

@firefart
Copy link
Contributor Author

firefart commented Jun 5, 2013

since the official bundler doc says you should check the file in, I think we can give it a try.
@ethicalhack3r @gbrindisi any other thoughts?

@ethicalhack3r
Copy link
Contributor

I'm not sure either :)

I don't think we've had any issue which this will solve? If it doesn't solve any issues, it could potentially create them?

@firefart
Copy link
Contributor Author

firefart commented Jun 5, 2013

yeah you're right. Closing it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants