Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitmap class cannot be used with already loaded image data #33

Open
stohrendorf opened this issue Jan 14, 2023 · 1 comment
Open

Bitmap class cannot be used with already loaded image data #33

stohrendorf opened this issue Jan 14, 2023 · 1 comment

Comments

@stohrendorf
Copy link

Consider an atlas image is created on the fly in memory in SRGBA8 format outside of etcpak. The Bitmap class can only be successfully constructed from a file, not from already present image data. When not providing a filename, m_sema is not initialized properly, so that later calls to NextBlock keep blocking, as the Bitmap class is effectively left uninitialized, and thus is not ready for data retrieval. It would be nice if either:

  1. the Bitmap class would get an additional constructor to construct it from already present image data, or
  2. the m_sema member would be initialized so that calls to NextBlock do not block for processing.

Thank you.

@wolfpld
Copy link
Owner

wolfpld commented Jan 15, 2023

Consider an atlas image is created on the fly in memory in SRGBA8 format outside of etcpak.

This is outside the scope of what etcpak aims to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants