Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert electron-builder version used in Electron template #323

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Sep 20, 2024

Description of change

  • fix: revert electron-builder version used in Electron template

There's an issue with Electron Builder >=25.0.1 where building an app produces an asar archive with a node_modules tree that uses wrong module versions, which causes the packaged app to behave differently than it does on dev mode, and very frequently crash or not load at all.
I'm downgrading the version of electron-builder used in the template electron app until this is fixed.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto September 20, 2024 02:05
@giladgd giladgd self-assigned this Sep 20, 2024
@giladgd giladgd changed the title fix: revert electron-builder version fix: revert electron-builder version used in Electron template Sep 20, 2024
@giladgd giladgd merged commit 6c644ff into beta Sep 20, 2024
7 checks passed
@giladgd giladgd deleted the gilad/fixElectronTemplate branch September 20, 2024 02:06
Copy link

🎉 This PR is included in version 3.0.0-beta.46 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Sep 24, 2024

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant