Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve streamed rpc calls #90

Closed
windmemory opened this issue Oct 16, 2020 · 2 comments
Closed

Improve streamed rpc calls #90

windmemory opened this issue Oct 16, 2020 · 2 comments
Labels
enhancement New feature or request proto Protocol Buffer

Comments

@windmemory
Copy link
Member

Currently the definition of streamed rpc calls having two problems:

  • MessageSendFile might transfer large data volume to server, so this function also needs to be converted to use stream
  • Converting the original filebox string to data bytes in the stream calls requires one more property: name, which means we need to add a name property to stream data.
@windmemory windmemory mentioned this issue Oct 16, 2020
Merged
@huan
Copy link
Member

huan commented Oct 16, 2020

Thank you very much for sharing your insights and for sending this great improvement PR!

@huan huan added enhancement New feature or request proto Protocol Buffer labels Oct 16, 2020
@windmemory
Copy link
Member Author

Let's close this issue since the PR is merged and changes are made in v0.18.1

@huan huan mentioned this issue Oct 24, 2020
Closed
@huan huan mentioned this issue Nov 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request proto Protocol Buffer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huan @windmemory