fix(deps): bump html-proxy-middleware to latest version #2616
Conversation
vtereshyn
requested review from
alexander-akait,
hiroppy and
knagaitsev
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #2616 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 34 34
Lines 1333 1333
Branches 381 381
=======================================
Hits 1250 1250
Misses 81 81
Partials 2 2
Continue to review full report at Codecov.
|
|
I am not sure what should I do with commit message |
package.json
Outdated
| @@ -45,7 +45,7 @@ | |||
| "del": "^4.1.1", | |||
| "express": "^4.17.1", | |||
| "html-entities": "^1.3.1", | |||
| "http-proxy-middleware": "0.19.1", | |||
| "http-proxy-middleware": "1.0.4", | |||
There was a problem hiding this comment.
How you use require changed in http-proxy-middleware version 1.0.0. Looks like you didn't update those statements.
https://github.com/chimurai/http-proxy-middleware/releases/tag/v1.0.0
v0.x.x with implicit require
const proxy = require('http-proxy-middleware');v1.0.0 with explicit require
const { createProxyMiddleware } = require('http-proxy-middleware');
There was a problem hiding this comment.
Wondering why this package's version is locked - does need to stay locked?
There was a problem hiding this comment.
probably, I changed locked version to the latest version and locked it.
There was a problem hiding this comment.
alright, I removed version locking and fixed http-proxy-middleware usage
vtereshyn
changed the title
vtereshyn
changed the title
|
Not sure what's wrong with tests and other stuff, but I ran tests, lints on my local machine several times and everything looks good. Also, I've tested webpack-dev-server locally with my app and everything looks good for me. |
|
Can't be merged for |
what should we do with |
|
@vtereshyn temporary you can don't audit dev dependencies |
|
@evilebottnawi I am not sure if security managers will like that way :) |
|
@evilebottnawi sorry, just wondering, which breaking changes are we talking about? I mean, I've checked this pull request with my application and everything looks good. But of course, you know better. thank you in advance |
|
I assume it's about Node.js version and the fact that http-proxy-middleware v1 supports Node v8 and higher while WDS v3 supports Node v6. |
|
@evilebottnawi thanks for the info! when can we expect v4 to be released? |
|
@lsiler-mdsol I am working on it, sorry can't provide ETA, because I am working only one, but I try to do it ASAP |
|
Just published Hopefully this'll ease the process to patch the current version of WDS without rushing to release [email protected] |
|
What do you think about releasing [email protected] now that there's a patch fix of |
|
i have submitted a PR with just patch of |
|
Done in v4, for v3 we can backport only #2665 |
This PR fixes an audit issue.
Also, in the scope of this pull request, I ran
npm audit fixto resolve some audit issues. That's why lots of changes inpackage-lock.json