Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tinyglobby #788

Open
benmccann opened this issue Oct 26, 2024 · 3 comments
Open

Switch to tinyglobby #788

benmccann opened this issue Oct 26, 2024 · 3 comments

Comments

@benmccann
Copy link
Contributor

Modification Proposal

Switch from globby to tinyglobby.

tinyglobby has quickly been adopted by vite and a number of other major projects as a much smaller near drop-in replacement for globby.

The main challenge with adopting it in this library is that the globby constructor options are directly exposed as an option here and the tinyglobby constructor options type is different, so it would be a breaking change that would have to be done in a major release.

Expected Behavior / Situation

https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

Actual Behavior / Situation

https://npmgraph.js.org/?q=globby - 23 dependencies

Please paste the results of npx webpack-cli info here, and mention other relevant information

n/a

@evenstensberg
Copy link
Member

Sounds good. I also think we can remove external libraries for globbing once we reach to the point that the lowest nodejs version supported allows us to use the native node glob.

Send a PR!

@benmccann
Copy link
Contributor Author

I've made a lot of progress on this. It seems that absolute: true needs to be set. It appears that globby has some bug that tinyglobby doesn't because the default is false, but globby seems to be returning absolute paths anyway. We need to set absolute: true to have tinyglobby also return absolute paths. Nearly all the tests pass once that's done. There's still one last issue I have to investigate

@alexander-akait
Copy link
Member

@benmccann Feel free to feedback if you will have questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants