Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1505 remove unused query-params.js #1599

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Fixes #1505 remove unused query-params.js #1599

merged 1 commit into from
Jun 20, 2017

Conversation

cch5ng
Copy link
Contributor

@cch5ng cch5ng commented Jun 19, 2017

@cch5ng
Copy link
Contributor Author

cch5ng commented Jun 19, 2017

@miketaylr (question resolved, sorry)
I'm also currently assigned to #1565 and am still searching through the code to understand what part of the code to update (change the api request parameters or filter the api response). but I was wondering do you think I should keep any of this removed file for filtering out media-type labelled issues from the webcompat.com issues list?

I did not look closely into the contents of query-params.js for this pr but can look again.

@cch5ng
Copy link
Contributor Author

cch5ng commented Jun 19, 2017

@miketaylr nvm, I think I found in github api docs info about the question I had earlier. I think it should be ok to just review this file removal.

@miketaylr miketaylr self-requested a review June 20, 2017 14:51
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you update the commit message to mention the query-params.js file (so its easier to understand when just reading history from the git log)?

You should just have to do something like this, from your branch:

git commit --amend
# update commit message, save commit file thingy
git push -f

THanks!

@cch5ng
Copy link
Contributor Author

cch5ng commented Jun 20, 2017

@miketaylr done

Can you update the commit message to mention the query-params.js file

@miketaylr miketaylr merged commit 930a564 into master Jun 20, 2017
@miketaylr
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants