tagging an issue from the list should happen once the window is closed

[karlcow]

1. Go to an issue
2. Select one or two tags

Actual: Tagging is happening right away as soon as we click the checkbox in the pop up window
Expected: Tagging should happen once leaving the pop up window.

Why: If we make mistakes in checking the boxes and changes while still in the pop up window, there is a dance of tagging happening in the history of the bug.

[miketaylr]

I agree.

[miketaylr]

Also a good opportunity to start on #272.

[miketaylr]

(just testing how github behaves here)

[miketaylr]

@karlcow just so I understand, we shouldn't update the UI with the labels that someone has picked until they Save/close the editor?

Right now we add/remove a label to the UI as soon as it is checked/unchecked, but don't send it to GitHub until the editor is closed.

I'm not attached to either behavior, so we can change it to only update UI when we send it to GitHub if you think that's a better model.

[karlcow]

Ah! I guess I got confused by the UI of webcompat.com.
So I guess it's fine. Maybe yes not showing it in the UI until we close the UI.

[karlcow]

Let's close it for now. Other priorities. And I will reopen that bug, when I'm in front of the same pattern which troubled me.

[miketaylr]

OK, thanks!