Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed/Open and bug status - two separate things #510

Closed
karlcow opened this issue Dec 24, 2014 · 15 comments
Closed

Closed/Open and bug status - two separate things #510

karlcow opened this issue Dec 24, 2014 · 15 comments

Comments

@karlcow
Copy link
Member

karlcow commented Dec 24, 2014

During a test of the UI on ipod touch 3, I noticed something which seems not very logical.

  1. Go to http://webcompat.com/
  2. Click on the all issues list icon
  3. Click on Closed.

The UI displays the list of closed issues, but we still have the "View All Open Issues" dropdown.

img_1002

I think it is related to the questions we have on bug #349


edit: Note, keeping in the backlog because of the design work in the comments.

@karlcow
Copy link
Member Author

karlcow commented Dec 24, 2014

OK let me rephrase a bit that issue so we can have a better place than #349 which was about contributors page.

@karlcow karlcow changed the title Open and Closed at the same time Closed/Open and bug status - two separate things Dec 24, 2014
@karlcow
Copy link
Member Author

karlcow commented Dec 24, 2014

@calexity @magsout important for the two of you. (I mean important for anyone. The rest will be development issues)

Context: This issue might be used to open other more atomic issues.

An issue has:

  • 2 status: Open / Closed
  • multiple labels with different facets. We discussed that a bit already in Organize labels #436.

Some labels are tied to the state in the workflow process. Some to the final stage of the issue. Let see if I can make more or less clear:

  • Open:
    • (untriaged)
    • needdiagnosis
    • readyforoutreach
    • sitewait
    • [probably a missing needcontact]
  • Closed:
    • fixed
    • invalid
    • wontfix
    • worksforme

The other labels are about categorization of the issues itself and not the workflow.

Currently the UI shows "View all Open Issues ﹀" which has:

  • Open
  • All (Open + Closed)

Proposal: Should we get rid of the dropdown, and have instead a:

[All] [Open] [Closed]

Proposal: Also when we click the [Closed], should we just hide all the workflow labels with are about the Open issues?

The workflow labels have a progression which might be represented as something more linear.

[ untriaged❯needdiagnosis❯needcontact❯readyforoutreach❯sitewait ]

On desktop the labels could be fully expanded, I think on mobile, there is something we could do to make it more compact. Something along a number or an abbreviation, that could be reused elsewhere in the design. Just to illustrate the idea, but don't take these labels as what it should be.

[ U❯ND❯NC❯RO❯SW ]

The benefits is that we will gain vertical space.

Finally there is the pagination. There are only 3 choices for the pagination we might not need a dropdown for this.

[20] [50] [100] 

could be enough.

Previous/Next might be handled in a different way. But that would be for another meta-issue. I think there are missing at the bottom of the list because, someone will not want to go back to the top to do next, specifically after a 100 issues scroll.

@karlcow
Copy link
Member Author

karlcow commented Dec 24, 2014

ok now I need to draw to illustrate the ideas and then see if @calexity and @magsout can make any sense of what I'm saying.

@karlcow
Copy link
Member Author

karlcow commented Dec 24, 2014

So in general the screen could be a bit like this.

  • hashed area is the "search field"
  • Open is selected
  • Outreach is selected

view-issues

Then if we scroll to view the issues. The search area comes to the top.

after-scroll

The status workflow bar could be icons such as

status-bar

  • arrows: untriaged
  • needdiagnosis: microscope
  • needcontact: Person? Addressbook
  • outreach: Mail? Phone? portable speaker?
  • Wait: clock

This would be expanded into their larger viewport versions. They also have a color code which is cool.

When Closed is selected the workflow labels could just disappear. They are not relevant anymore.
closed

@karlcow
Copy link
Member Author

karlcow commented Dec 24, 2014

In this design they used an option near the search box
https://dribbble.com/shots/459333-Filter-by-Name

@calexity
Copy link
Contributor

@karlcow @magsout check this out. Karl, your drawings are a little hard to see, but I think I understand what you are saying.

Guillaume had suggested something like this a while ago:

screen shot 2014-12-27 at 5 32 20 pm

that could open up this (which could probably hold about 10 filters), maybe 20 if we made them 2 column

screen shot 2014-12-27 at 5 33 21 pm

On larger screens we could do the arrows that I think @tagawa suggested:

screen shot 2014-12-27 at 5 33 34 pm

I think that desktop design needs more work. IGNORE ALL THE COLORS. They are just to illustrate.

@tagawa
Copy link
Member

tagawa commented Dec 28, 2014

I like both these and yes, the arrow thing is exactly what I was trying to suggest.

@calexity
Copy link
Contributor

PS @karlcow I added the icons you suggested to this bug - #482

Here's an example of that
desktopicons

@karlcow
Copy link
Member Author

karlcow commented Dec 29, 2014

@calexity I will improve the drawings. I found a scanner around here. ;)
The suggestions are indeed progress in the right direction. That's very cool.
We need to work a bit for making some of the things glanceable and not loosing too much space on mobile and have a good transition in between desktop and mobile.

@magsout
Copy link
Member

magsout commented Jan 3, 2015

@karlcow very interesting analysis, and many good point. I love the idea of the filters.

Proposal: Should we get rid of the dropdown, and have instead a:
[All] [Open] [Closed]

@karlcow , @calexity On desktop, maybe add the dropdown with the stats (all, close, open) next to the dropdowns "newest" and "show X" ?

On small devices, we could have in the order of appearance

  • As a button (appearance): Open- closed - filter
  • SearchBar
  • IssueList
  • Pagination (only at bottom)
  1. click on open: all open issue appear
  2. click on closed: all closed issue appear
  3. click on filter : all filter (news, need diagnosis, need contact etc..) appear and the two dropdown : Show by and Sort by.

And what about :

  • View Issues Submitted by Me ?
  • View Issues Mentioning Me ?

I don't use these information on Github, but maybe the other yes, so is it relevant or not ?

@calexity
Copy link
Contributor

@magsout @karlcow

Another option, just adding back Closed. I know there is some complexity to closed but it seems like between search and these filters, you could find the bug you were looking for. By default, we only show open bugs unless you select closed. Closed is not selected upon page load and all other filters are.

Small
smallfilter


Large
desktop add filter

Re: "issues submitted by me" and "issues mentioning me", I think that's a great idea for the issue dashboard filter (where it says Saved Issues) - #442

@karlcow
Copy link
Member Author

karlcow commented Jul 30, 2015

note that the labels reorg has landed. So that will make a lot things easier, at least for writing code.

@hallvors
Copy link
Contributor

@calexity love those small icons on the status labels! ❤️

@adamopenweb
Copy link
Collaborator

I agree the icons look great! I also like the reduced height of each item in the issue list.

@miketaylr
Copy link
Member

Note: we like these designs and want to come back to them. But the issue around filtering on closed will be made obsolete by #1527.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants