Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webdriver test for pointer_move action within an iframe #48123

Merged

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Sep 12, 2024

Those added tests demonstrate that for both Chrome and Safari the pointer actions are misbehaving when executed within an iframe. The target coordinates as defined for the action aren't reached because the offset of the iframe isn't taken into account.

CC @sadym-chromium and @gsnedders

@whimboo
Copy link
Contributor Author

whimboo commented Sep 12, 2024

@jgraham or @juliandescottes can you please review?

Copy link
Contributor

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

webdriver/tests/classic/perform_actions/pointer_mouse.py Outdated Show resolved Hide resolved
@whimboo whimboo force-pushed the wdspec-frame-pointer-move branch from 0d8a041 to de8ad8b Compare September 16, 2024 08:35
@whimboo whimboo merged commit defcb17 into web-platform-tests:master Sep 16, 2024
19 checks passed
@whimboo whimboo deleted the wdspec-frame-pointer-move branch September 16, 2024 09:44
@whimboo
Copy link
Contributor Author

whimboo commented Sep 20, 2024

The Chromium related bug is: GoogleChromeLabs/chromium-bidi#2630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants