Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid HTML: /> syntax on non-void elements #40473

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Fix invalid HTML: /> syntax on non-void elements #40473

merged 4 commits into from
Jun 12, 2023

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 9, 2023 •
edited
Loading

In VSCode, I searched for

<(a|abbr|article|audio|b|bdi|bdo|blockquote|body|button|canvas|caption|cite|code|colgroup|data|datalist|dd|del|details|dfn|dialog|div|dl|dt|em|fieldset|figcaption|figure|footer|form|h[1-6]|head|header|html|i|iframe|ins|kbd|label|legend|li|main|map|mark|menu|meter|nav|noscript|object|ol|optgroup|option|output|p|picture|pre|progress|q|rp|rt|ruby|s|samp|script|search|section|select|slot|small|span|strong|style|sub|summary|sup|table|tbody|td|template|textarea|tfoot|th|thead|time|title|tr|u|ul|var|video)(\s+[^>]+)?\s*/>

and replaced with

<$1$2></$1>

(with some manual fixups)

Files to include: *.html, *.htm
Files to exclude: dom/nodes/, domparsing/, quirks/, conformance-checkers/, acid/ (these are testing XML parsing, except Acid3 which has pseudo-markup in comments)

@wpt-pr-bot wpt-pr-bot requested a review from RByers June 9, 2023 13:22
annevk
annevk approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please carefully check before/after results in browsers.

css/css-scoping/shadow-cascade-order-001.html Outdated Show resolved Hide resolved
reillyeon
reillyeon approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

media-capture LGTM, I assume that's why the bot wants me to look at this.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 12, 2023

0 diff in test results vs merge base:

@zcorpan zcorpan merged commit f620b1e into master Jun 12, 2023
@zcorpan zcorpan deleted the zcorpan/fix-non-void-tags branch June 12, 2023 10:02
zcorpan added a commit that referenced this pull request Jun 12, 2023
@zcorpan
Add a lint rule for /> syntax on non-void HTML elements
061f574 
See #40473
@zcorpan zcorpan mentioned this pull request Jun 12, 2023
Merged
@zcorpan zcorpan mentioned this pull request Aug 28, 2023
Open
@zcorpan zcorpan mentioned this pull request Sep 20, 2023
Open
zcorpan added a commit that referenced this pull request Sep 20, 2023
@zcorpan
Add a lint rule for /> syntax on non-void HTML elements
894923a 
See #40473
zcorpan added a commit that referenced this pull request Sep 20, 2023
@zcorpan
Add a lint rule for /> syntax on non-void HTML elements
db6e503 
See #40473
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
@zcorpan @Lightning00Blade
Add a lint rule for /> syntax on non-void HTML elements
8c8f03c 
See web-platform-tests#40473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic left review comments

@npm1 npm1 npm1 approved these changes

@Steditor Steditor Steditor approved these changes

@annevk annevk annevk approved these changes

@alvestrand alvestrand alvestrand approved these changes

@reillyeon reillyeon reillyeon approved these changes

@AmeliaBR AmeliaBR Awaiting requested review from AmeliaBR

@birtles birtles Awaiting requested review from birtles

@dbaron dbaron Awaiting requested review from dbaron

@dirkschulze dirkschulze Awaiting requested review from dirkschulze

@fantasai fantasai Awaiting requested review from fantasai

@foolip foolip Awaiting requested review from foolip

@frivoal frivoal Awaiting requested review from frivoal

@fserb fserb Awaiting requested review from fserb

@grorg grorg Awaiting requested review from grorg

@guidou guidou Awaiting requested review from guidou

@hayatoito hayatoito Awaiting requested review from hayatoito

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

@henbos henbos Awaiting requested review from henbos

@hillbrad hillbrad Awaiting requested review from hillbrad

@igrigorik igrigorik Awaiting requested review from igrigorik

@jan-ivar jan-ivar Awaiting requested review from jan-ivar

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@kenrussell kenrussell Awaiting requested review from kenrussell

@klausw klausw Awaiting requested review from klausw

@kojiishi kojiishi Awaiting requested review from kojiishi

@mikewest mikewest Awaiting requested review from mikewest

@NavidZ NavidZ Awaiting requested review from NavidZ

@plehegar plehegar Awaiting requested review from plehegar

@plinss plinss Awaiting requested review from plinss

@RByers RByers Awaiting requested review from RByers

@rniwa rniwa Awaiting requested review from rniwa

@rwaldron rwaldron Awaiting requested review from rwaldron

@snuggs snuggs Awaiting requested review from snuggs

@tabatkins tabatkins Awaiting requested review from tabatkins

@TakayoshiKochi TakayoshiKochi Awaiting requested review from TakayoshiKochi

@tarunban tarunban Awaiting requested review from tarunban

@yell0wd0g yell0wd0g Awaiting requested review from yell0wd0g

@yoavweiss yoavweiss Awaiting requested review from yoavweiss

@youennf youennf Awaiting requested review from youennf

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@alvestrand alvestrand

Labels
accessibility client-hints content-security-policy css-animations css-backgrounds css-cascade css-display css-masking css-scoping element-timing html largest-contentful-paint mediacapture-image mediacapture-record pointerevents selectors shadow-dom trusted-types video-rvfc webrtc webxr wg-css wg-immersive-web wg-s_pointer-events wg-s_webappsec wg-s_webrtc wg-webperf wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zcorpan @reillyeon @alvestrand @domenic @annevk @Steditor @npm1 @wpt-pr-bot