fix: deal with boolean attribute with empty value (#660)

web-infra-dev · Feb 18, 2024 · 9a61e57 · 9a61e57
1 parent e6832e0
commit 9a61e57
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/packages/core/src/module/app.ts b/packages/core/src/module/app.ts
@@ -714,10 +714,9 @@ export class App {
               async: false,
               defer: false,
               isInline: jsManager.isInlineScript(),
-              noEntry: toBoolean(
-                entryManager.findAttributeValue(node, 'no-entry') ||
-                  this.isNoEntryScript(targetUrl),
-              ),
+              noEntry:
+                toBoolean(entryManager.findAttributeValue(node, 'no-entry')) ||
+                toBoolean(this.isNoEntryScript(targetUrl)),
               originScript: mockOriginScript,
             });
           }

diff --git a/packages/core/src/module/resource.ts b/packages/core/src/module/resource.ts
@@ -22,10 +22,13 @@ function fetchStaticResources(
       .map((node) => {
         const src = entryManager.findAttributeValue(node, 'src');
         const type = entryManager.findAttributeValue(node, 'type');
-        const crossOrigin = entryManager.findAttributeValue(
+        let crossOrigin = entryManager.findAttributeValue(
           node,
           'crossorigin',
         );
+        if (crossOrigin === '') {
+          crossOrigin = 'anonymous';
+        }
 
         // There should be no embedded script in the script element tag with the src attribute specified
         if (src) {

diff --git a/packages/loader/src/managers/template.ts b/packages/loader/src/managers/template.ts
@@ -144,7 +144,7 @@ export class TemplateManager {
   }
 
   findAttributeValue(node: Node, type: string) {
-    return node.attributes?.find(({ key }) => key === type)?.value || undefined;
+    return node.attributes?.find(({ key }) => key === type)?.value ?? undefined;
   }
 
   cloneNode(node: Node) {