Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Vsts git support #1870

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Vsts git support #1870

merged 1 commit into from
Mar 27, 2019

Conversation

dpmerron-ltd
Copy link
Contributor

I have added support for legacy Azure DevOps git accounts that have been migrated from VSTS to Azure DevOps.

Instead of the host ssh.dev.azure.com it uses vs-ssh.visualstudio.com.

Updated documentation to reflect these changes also.

I have been unable to run tests as I can't seem to get the code to compile - errors finding ./fluxctl so wondered if someone else were able to pick up the testing part on my behalf? Happy to spend more time to do it but right now have other important things I need to work on.

Any feedback, or suggestions appreciated.

@squaremo
Copy link
Member

Looks reasonable, thank you @dpmerron-ltd. One thing: can you mention the method used to obtain the fingerprint, in the comment in verify-known-hosts.sh -- ta.

site/faq.md Outdated Show resolved Hide resolved
@dpmerron-ltd
Copy link
Contributor Author

dpmerron-ltd commented Mar 27, 2019

Looks reasonable, thank you @dpmerron-ltd. One thing: can you mention the method used to obtain the fingerprint, in the comment in verify-known-hosts.sh -- ta.

@squaremo I have added that comment - just added to the existing Azure DevOps comment with an & as the process is exactly the same.

Edit: Oops - didn't spot that s

Dan

@squaremo
Copy link
Member

squaremo commented Mar 27, 2019

just added to the existing Azure DevOps comment

Great, thanks for that -- I also found somewhere it's actually published https://docs.microsoft.com/en-us/azure/devops/repos/git/use-ssh-keys-to-authenticate?view=azure-devops

Sorry for this last bit of busywork: can you squash it all into one commit, please (we've got up to seven, with the github suggestions, etc.)

EDIT: nvm, done it for you :-)

@squaremo squaremo merged commit e220d2c into fluxcd:master Mar 27, 2019
@squaremo
Copy link
Member

Thanks @dpmerron-ltd! (and @hiddeco for the review)

@dpmerron-ltd
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants