This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Admit "<cluster>" when parsing ResourceIDs #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR #1442 introduce code to determine which namespace, if any, each manifest belongs to. To distinguish between resources that need a namespace but don't have one, and resources that are cluster-scoped, it introduced the sentinel value `<cluster>` for the latter. Regrettably, I didn't accompany this with code for _parsing_ those sentinel values, since I reasoned that it would only be used internally. But the sync events generated by fluxd include a list of changed resources, and those inevitably will include things like namespaces that are cluster-scoped. The result is that fluxd will generate events that cannot then be parsed by the receiver. This commit fixes that by recognising `<cluster>` as a namespace when parsing resource IDs.
2opremio
approved these changes
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1442 introduce code to determine which namespace, if any, each
manifest belongs to. To distinguish between resources that need a
namespace but don't have one, and resources that are cluster-scoped,
it introduced the sentinel value
<cluster>for the latter.Regrettably, I didn't accompany this with code for parsing those
sentinel values, since I reasoned that it would only be used
internally. But the sync events generated by fluxd include a list of
changed resources, and those inevitably will include things like
namespaces that are cluster-scoped. The result is that fluxd will
generate events that cannot then be parsed by the receiver.
This commit fixes that by recognising
<cluster>as a namespace whenparsing resource IDs.