This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Take ignore policy into account when working with automated resources #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
suggested changes
Feb 19, 2019
|
Arguably, we should not bother updating resources when they have the ignore annotation either in the file, or in the cluster resource, since the latter still gives surprising results -- the resource looks like it should have been updated, and visibly isn't. To do that, we'll also need to skip ignored resources when calculating the commit to make. |
Having put forward that argument, I think this PR unambiguously improves things as it is. |
Before this change having a HelmRelease annotated with both 'automated' and 'ignore' put automated releases to a halt for all resources known to Flux. The reason for this was the image check failing while comparing with a non-existent controller, resulting in an early error return; which short circuited image updates for everything else.
hiddeco
force-pushed
the
1748-automated-ignore-clash
branch
from
0100805 to
de33ad2
Compare
I like cherries on my cake (or icing on the cake, as you English people would say) so I added a filter. |
hiddeco
changed the title
2opremio
approved these changes
Feb 19, 2019
squaremo
reviewed
Feb 19, 2019
hiddeco
force-pushed
the
1748-automated-ignore-clash
branch
from
ace307e to
84f37a4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1748
Before this change having a HelmRelease annotated with both 'automated' and 'ignore' put automated releases to a halt for all resources known to Flux.
The reason for this was the image check failing while comparing with a non-existent controller, resulting in an early error return; which short circuited image updates for everything else.