This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Put baked-in SSH config in /etc/ssh #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present we bake SSH config (ssh_config and known_hosts) into the flux image at the user-specific location, that is `/root/.ssh/`. This makes it fiddly to override by mounting a configmap, because you have to specify subPath (which stops Kubernetes from updating the file when the configmap changes), or supply both files. If we put our baked-in config at the global location (`/etc/ssh`), people are free to mount a configmap at `/root/.ssh` without the limitations above. This means we can unconditionally mount a (probably empty) configmap in the example and in Helm charts.
aaron7
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to use a self-hosted (or unaccounted for) git server, you have to be able to put its host key in known_hosts in the fluxd container. This is because we make sure
StrictHostKeyCheckingis enabled for SSH.At present we bake SSH config (ssh_config and known_hosts) into the flux image at the user-specific location, that is
/root/.ssh/. This makes it fiddly to override known_hosts by mounting a configmap, because you have to specify subPath (which stops Kubernetes from updating the file when the configmap changes), or supply both files.If we put our baked-in config at the global location (
/etc/ssh), people are free to mount a configmap at/root/.sshwithout the limitations above. This means we can unconditionally mount a (probably empty) configmap in the example and in Helm charts.