Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Log the daemon version on startup #1017

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Log the daemon version on startup #1017

merged 1 commit into from
Mar 23, 2018

Conversation

samb1729
Copy link
Contributor

If a new flux release isn't adding to our checkpoint-api, there's some potentially misleading log output on daemon startup.

Specifically, we were seeing this output when running flux 1.2.5:

ts=2018-03-22T08:57:19.895914653Z caller=checkpoint.go:24 component=checkpoint msg="up to date" version=1.2.4

@samb1729 samb1729 requested a review from rade March 22, 2018 10:22
@squaremo
Copy link
Member

It'd be nice to change the uptodate log message too -- I always see it and think it's reporting the current version.

@samb1729 samb1729 force-pushed the log-version-on-startup branch from 55f61a2 to 888c10f Compare March 22, 2018 12:56
@samb1729 samb1729 requested a review from squaremo March 22, 2018 12:56
@samb1729
Copy link
Contributor Author

@squaremo I've changed the version label to latest instead, because I reckon that's more clear. go-kit wouldn't let me use latest-version.

Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nice one.

This also changes the key used when printing the latest flux version, as
reported by checkpoint, to make it less confusing to read.
@samb1729 samb1729 force-pushed the log-version-on-startup branch from 888c10f to 6911497 Compare March 23, 2018 15:33
@samb1729 samb1729 merged commit 3d56be4 into master Mar 23, 2018
@samb1729 samb1729 deleted the log-version-on-startup branch March 23, 2018 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants