Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing REIs #22

Open
Ben-Davis1 opened this issue Jan 27, 2020 · 1 comment
Open

Add missing REIs #22

Ben-Davis1 opened this issue Jan 27, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Ben-Davis1
Copy link
Contributor

We need to add any missing REIs throughout the project. This is especially important for places where we have fixed the duplication of bs.as (see #21) as some modules shouldn't be available for use outside of the module they're defined in.

It would be good to make a list of needed REIs in this issue so we can work on it

@Ben-Davis1 Ben-Davis1 added the enhancement New feature or request label Jan 27, 2020
@Ben-Davis1 Ben-Davis1 added this to the 1.0.0-alpha milestone Jan 27, 2020
@tsnobip
Copy link
Contributor

tsnobip commented Jan 27, 2020

I think the missing .rei files are:

What might be more cumbersome and error-prone is changing the existing .rei files to use external instead of let and add all the bs annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants