Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to IBM/ruby-sdk-core#33
I was integrating with the Ruby SDK in a rails app, which runs ruby 2.7.2. I wasn't able to initialize an
IamAuthenticator
object in that lib and traced it down to the http gem. Relevant stack trace portion:I came across this fix in the http gem repo that references the frozen string error. It was backported to http gem version 4.3.0. This PR updates the gem dependency, but it conflicted with the dependency in the ruby-sdk-core repo so I updated that one as well in this PR. After this fix (and the one in that repo) the code ran fine in rails on ruby 2.7.2 I'm running the project from gem sources in github at the moment, but here's a PR in case you want to update officially. This PR changes the dep to 4.4.x, but 4.1 -> 4.4 should be backwards-compatible. I'm not an expert at minitest but it seems all the tests pass with these changes (at least the ones triggered by
bundle exec rake
.Cheers