Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openid4vc verifiy policy "presentation-definition", why can verified success, with credentials out of list request_credentials. #842

Open
thanachot30 opened this issue Dec 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@thanachot30
Copy link

Describe the bug

I am currently testing the verifier using the "presentation-definition" policy. From my understanding, the "presentation-definition" policy works by checking the VP to see if the presented credentials match exactly with the list in request_credentials. If everything matches perfectly, it passes. However, if there are any missing or additional credentials, it results in an error.

But today, I tested it, and it failed.

To Reproduce

useing walt.id v0.9.0
Steps to reproduce the behavior:

  1. create Presentation definition for verifier (https://verifier.portal.walt.id)
{
   "vp_policies": [
      "signature",
      "expired",
      "not-before",
      "presentation-definition"
   ],
   "vc_policies": [
      "signature",
      "expired",
      "not-before"
   ],
   "request_credentials": [
      {
         "format": "jwt_vc_json",
         "type": "BankId"
      },
      {
         "format": "jwt_vc_json",
         "type": "PND91Credential"
      }
   ]
}

for get qr
2. go to walt.id wallet (https://wallet.walt.id/login)
and present
this is list vc for present (So, in list is not have "PND91Credential")
vc_5

and send disclose

  1. the result of verifier is 'success', !!!!
vc_6

why i can verifier success ?,

Expected behavior

i Expected error verifier and throw error "missingCredentialTypes"

@thanachot30 thanachot30 added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant