Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erase_water() should return input_sf if there is no overlap w/ water area #172

Open
elipousson opened this issue Aug 3, 2023 · 1 comment · May be fixed by #173
Open

erase_water() should return input_sf if there is no overlap w/ water area #172

elipousson opened this issue Aug 3, 2023 · 1 comment · May be fixed by #173

Comments

@elipousson
Copy link

While trying to use erase_water() on a subset of tracts for an area, I realized that it returns an empty data frame if there is no overlapping water area. I just implemented a fix on my fork that I think also may improve performance for erase_water() since it incorporates the filter_by parameter when calling tigris::counties().

I'm optimistic this will be a welcome change so I'll go ahead and open a pull request for review.

elipousson added a commit to elipousson/tigris that referenced this issue Aug 4, 2023
Also adds is_sf helper
@walkerke
Copy link
Owner

walkerke commented Aug 7, 2023

Thank you! I'll take a look at this. I wonder if this is an issue on the Python side as well, I'll have to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants