Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected code highlighting #2280

Closed
1 of 2 tasks
SheetJSDev opened this issue Jan 9, 2023 · 1 comment
Closed
1 of 2 tasks

Unexpected code highlighting #2280

SheetJSDev opened this issue Jan 9, 2023 · 1 comment
Labels
Documentation Improvements or additions to documentation Good First Issue Good for newcomers TODO The issue is ready to be developed

Comments

@SheetJSDev
Copy link
Contributor

Have you read the Documentation Contribution Guidelines?

Description

Some of the code blocks in the docs have changed. The highlights are specified with line numbers but those were not updated.

For example https://wails.io/docs/howdoesitwork#method-binding

howdoesitwork

When the highlights were last set (commit dce5fd4), the equivalent of lines 17 (app := &App{}) and 27 (app,) were highlighted.

After that commit, two more commits added lines to the code block without updating the highlights.

It looks like the wails.io is using Docusaurus. It supports special comments for highlighting lines.

Self-service

  • I'd be willing to address this documentation request myself.
@SheetJSDev SheetJSDev added the Documentation Improvements or additions to documentation label Jan 9, 2023
@leaanthony
Copy link
Member

Oh nice catch! I'll fix that tonight

@leaanthony leaanthony added Good First Issue Good for newcomers TODO The issue is ready to be developed labels Jan 9, 2023
BuckeyeCoder added a commit to BuckeyeCoder/wails that referenced this issue Feb 1, 2023
BuckeyeCoder added a commit to BuckeyeCoder/wails that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Good First Issue Good for newcomers TODO The issue is ready to be developed
Projects
None yet
Development

No branches or pull requests

2 participants