Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Babe Spec and Babe Implementation with Babe paper #144

Closed
drskalman opened this issue Mar 10, 2020 · 7 comments
Closed

Compare Babe Spec and Babe Implementation with Babe paper #144

drskalman opened this issue Mar 10, 2020 · 7 comments
Assignees

Comments

@drskalman
Copy link
Contributor

We need to compare babe implementation with babe spec and submit any discrepency to research-security-issues repo.

@drskalman
Copy link
Contributor Author

Currently the more important part is the relative time protocol part of it because the slot selection part is going to be replaced by the SASS.

Babe research write up can be found here:

https://github.com/w3f/research/blob/master/docs/polkadot/BABE/Babe.md
But check with @hndnklnc for the latest write up.

@hndnklnc
Copy link

It is the latest writeup. If you have any questions, you can ask me.

@FlorianFranzen
Copy link
Contributor

I am updating our spec to the latest write up right now. Current progress it tracked in w3f/research-internal#110

@drskalman
Copy link
Contributor Author

@FlorianFranzen is going to the current host spec according to the latest babe spec with recent constant hardcoded.

@drskalman
Copy link
Contributor Author

The Babe spec is being followed up in issue #168
And the descrepancy between the rust implementation and the Spec is discussed in https://github.com/w3f/research-security-issues/issues/7

@burdges
Copy link
Contributor

burdges commented May 2, 2020

I found the randomness was not being recycled correctly, to which wei proposed a fix in paritytech/substrate#5788 although they'll compare with another fix approach.

We should figure out if the randomness recycles from one epoch waits long enough before being used in another epoch.

@burdges
Copy link
Contributor

burdges commented May 4, 2020

Fix merged paritytech/substrate#5876

I donno if they merged the whole migration machinery yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants