-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunset UMD support #514
Comments
Hey @foolip, would this be okay for WPT and the BCD collector? |
I'm sure I can adapt mdn-bcd-collector to whatever the change is, but for WPT I'm not sure. Will the generated script we use be different in some way? |
Yeah, sunsetting UMD will force the consumers to use ES module instead. For Node.js I guess it hopefully shouldn't be a breaking change unless anyone is still using pre-module version of Node.js (... that is Node 12, which still is an active LTS. 🤔), but in browsers - <script src=/resources/WebIDLParser.js></script>
+ <script module>
+ import * as WebIDL2 from "/resources/webidl2/lib/webidl2.js";
+ globalThis.WebIDL2 = WebIDL2;
+ </script> All targets of WPT support Edit:
I think I misunderstood this. The API and its output shouldn't change. |
|
This isn't doable without a serious breaking change since |
Node.js 15.3.0 marked ESM support as stable. Since Node.js and browsers have supported ESM for years (with two Node.js LTS versions), it should be okay to sunset the UMD one.
See also #494
The text was updated successfully, but these errors were encountered: