Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][2.6.12] Combobox 'allow-overflow' is not working #16008

Closed
MayaElf opened this issue Nov 1, 2022 · 6 comments
Closed

[Bug Report][2.6.12] Combobox 'allow-overflow' is not working #16008

MayaElf opened this issue Nov 1, 2022 · 6 comments
Assignees
Labels
C: VAutocomplete VAutocomplete T: bug Functionality that does not work as intended/expected
Milestone

Comments

@MayaElf
Copy link

MayaElf commented Nov 1, 2022

Environment

Vuetify Version: 2.6.12
Vue Version: 2.6.11
Browsers: Chrome 106.0.0.0
OS: Windows 10

Steps to reproduce

  1. open Combobox
  2. put 'allow-overflow' = false
  3. and then for another combobox 'allow-overflow' = true

Expected Behavior

Behaviour is different for 'allow-overflow' = false vs =true

Actual Behavior

Behaviour is the same for 'allow-overflow' = false vs =true

Reproduction Link

https://codepen.io/MaiiaAfanaseva/pen/ZERQJXO?editors=1010

@Z3rio
Copy link
Contributor

Z3rio commented Nov 2, 2022

What would the expected behaviour for false be.
Allowing overflow would obviously mean that it scrolls when overflowed, which it does.
But what would you want to happen when it is set to false?

Do you think that the scrolling should be removed, and instead all the items should be displayed without scrolling // kinda like setting the height to fit-content.
Or should it just cut off the items that are overflowed?

@MayaElf
Copy link
Author

MayaElf commented Nov 2, 2022

@Z3rio In Vuetify you have implementation of 'allow-overflow' for v-menu. I added it to examples in codepen https://codepen.io/MaiiaAfanaseva/pen/ZERQJXO?editors=1010
I believe the implementation for v-combobox should be the same as in v-menu.

@KaelWD
Copy link
Member

KaelWD commented Nov 2, 2022

This was missed in f5a3f82, and looks like it wasn't hooked up correctly even then. Since v1.2.0 the correct way to pass additional props to v-menu is through the menu-props prop.

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VAutocomplete VAutocomplete and removed S: triage labels Nov 2, 2022
@KaelWD KaelWD self-assigned this Nov 2, 2022
@KaelWD KaelWD added this to the v2.6.x milestone Nov 2, 2022
@Z3rio
Copy link
Contributor

Z3rio commented Nov 2, 2022

Okay, I will take a look at this.

@MayaElf
Copy link
Author

MayaElf commented Nov 4, 2022

@KaelWD Sorry, my issue was about v-combobox. So in api-documentation for v-combobox 'allow-overflow' will be deleted?

@KaelWD
Copy link
Member

KaelWD commented Nov 4, 2022

Yes, it extends VAutocomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete VAutocomplete T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

3 participants