You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In nodejs v10, an underlying library made a change that broke doing things like reading a writable only stream.
This means the following line alone would now cause an error:
process.stdout.on('data',()=>{});
The error actually occurs on nodejs v8, but it doesn't close the writable stream like it does on nodejs v10, which is, I'm guessing, why it wasn't noticed.
Bug report
Version
vuepress 1.0.0-alpha.25
Steps to reproduce
Reproduction repo: https://github.com/spiltcoffee/vuepress-dev-crash
Note: Requires nodejs v10 or greater to reproduce.
What is expected?
vuepress dev
to workWhat is actually happening?
vuepress dev
crashes.I think it's related to PR #1051 / commit e570252
In nodejs v10, an underlying library made a change that broke doing things like reading a writable only stream.
This means the following line alone would now cause an error:
The error actually occurs on nodejs v8, but it doesn't close the writable stream like it does on nodejs v10, which is, I'm guessing, why it wasn't noticed.
More info: nodejs/node#21203
Other relevant information
p.s. sorry for not raising this as an issue earlier, instead insisting on commenting on a closed pull request. My bad!
The text was updated successfully, but these errors were encountered: