Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuepress dev broken on nodejs v10 and greater #1063

Closed
1 task done
spiltcoffee opened this issue Dec 3, 2018 · 1 comment
Closed
1 task done

vuepress dev broken on nodejs v10 and greater #1063

spiltcoffee opened this issue Dec 3, 2018 · 1 comment

Comments

@spiltcoffee
Copy link
Contributor

  • I confirm that this is a issue rather than a question.

Bug report

Version

vuepress 1.0.0-alpha.25

Steps to reproduce

Reproduction repo: https://github.com/spiltcoffee/vuepress-dev-crash
Note: Requires nodejs v10 or greater to reproduce.

What is expected?

vuepress dev to work

What is actually happening?

vuepress dev crashes.

I think it's related to PR #1051 / commit e570252

In nodejs v10, an underlying library made a change that broke doing things like reading a writable only stream.

This means the following line alone would now cause an error:

process.stdout.on('data', () => {});

The error actually occurs on nodejs v8, but it doesn't close the writable stream like it does on nodejs v10, which is, I'm guessing, why it wasn't noticed.

More info: nodejs/node#21203

Other relevant information

  • Your OS: Windows 10
  • Node.js version: v10.14.1
  • Browser version: Chrome 70
  • Is this a global or local install? Local
  • Which package manager did you use for the install? npm 6.1.0

p.s. sorry for not raising this as an issue earlier, instead insisting on commenting on a closed pull request. My bad!

@spiltcoffee spiltcoffee changed the title dev broken on nodejs v10 and greater vuepress dev broken on nodejs v10 and greater Dec 3, 2018
@ulivz ulivz closed this as completed in 39e9673 Dec 3, 2018
@ulivz
Copy link
Member

ulivz commented Dec 3, 2018

Thanks for the report, fixed and released at 1.0.0-alpha.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants