Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need lodash in instances of vorpal? #23

Open
hongaar opened this issue Nov 20, 2019 · 2 comments
Open

Do we need lodash in instances of vorpal? #23

hongaar opened this issue Nov 20, 2019 · 2 comments

Comments

@hongaar
Copy link
Member

hongaar commented Nov 20, 2019 •
edited
Loading

Currently, the entire lodash library is added to instances of vorpal. Do we really need this? It's quite annoying when you console.log(vorpal).

Might want to try to remove it and see if tests pass.
@AdrieanKhisbe
Copy link
Member

We could make it optional.
(and maybe add a way to have the /fpflavor out of it)

(But why do you console.log(vorpal) in the first place ? 🤔 ^^)

@hongaar
Copy link
Member Author

hongaar commented Nov 20, 2019

(But why do you console.log(vorpal) in the first place ? 🤔 ^^)

Inspection (there used to be a time when there was no TS version of Vorpal 😉)

@Ore4444 Ore4444 mentioned this issue Dec 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hongaar @AdrieanKhisbe