-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed-Tab: iframe contains invalid attributes #31
Comments
They might be invalid per spec but they are interpreted by browsers and indeed necessary to provide the required user experience. For example Mozilla based browsers will not allow iframes to open a fullscreen-view for iw. a Video-Player, without the fullscreen-Attribute (See MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#attr-allowfullscreen or even MSDN: https://msdn.microsoft.com/de-de/library/dn312070(v=vs.85).aspx and this SO-Post for an overview of browser Support: http://stackoverflow.com/questions/18113909/how-widely-supported-is-the-iframe-attribute-allowfullscreen) |
I think overall we can still do better:
My (untested) suggestion would be:
|
Apparently I've successfully tested the following in Firefox and Chrome:
It appears to yield the same result as the original (except it removes borders in Firefox). |
iframe tag to embed streams uses invalid/unsupported attributes "frameborder", "allowfullscreen", "seamless" and "scrolling", which could lead to unexpected behavior of browsers.
The text was updated successfully, but these errors were encountered: