Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix velero install example #8373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fxierh
Copy link

@fxierh fxierh commented Nov 5, 2024

The storageAccount key passed to the velero install --backup-location-config argument should contain the storage account name, not the storage account ID.

/kind changelog-not-required

Signed-off-by: Feilian Xie <[email protected]>
@fxierh fxierh force-pushed the fix-velero-install-example branch from f8cdf8a to 5ca3add Compare November 5, 2024 17:36
@kaovilai
Copy link
Member

kaovilai commented Nov 5, 2024

The "ID" came from the variable defined like following.

AZURE_STORAGE_ACCOUNT_ID="velero$(uuidgen | cut -d '-' -f5 | tr '[A-Z]' '[a-z]')"
az storage account create \
    --name $AZURE_STORAGE_ACCOUNT_ID \
    --resource-group $AZURE_BACKUP_RESOURCE_GROUP \
    --sku Standard_GRS \
    --encryption-services blob \
    --https-only true \
    --min-tls-version TLS1_2 \
    --kind BlobStorage \
    --access-tier Hot

which is in fact, a name used to create storage account.

If you prefer that the variable used be _NAME, I would first update the azure plugin docs.

Once the plugin repo PR is approved and merged, we can accept this PR.

@ywk253100 ywk253100 self-requested a review November 11, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants