Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRD keep annotation 'helm.sh/resource-policy' #587

Open
nonamef opened this issue Jun 11, 2024 · 2 comments
Open

Add CRD keep annotation 'helm.sh/resource-policy' #587

nonamef opened this issue Jun 11, 2024 · 2 comments

Comments

@nonamef
Copy link

nonamef commented Jun 11, 2024

Describe the problem/challenge you have
If you delete the helm chart, all CRDs will be removed. Would like to keep the CRDs/CRs when deleting the chart.

Describe the solution you'd like
Add an option to append the annotation 'helm.sh/resource-policy: keep' to all CRDs.
e.g
metadata: {{- if .Values.crds.keep }} annotations: helm.sh/resource-policy: keep {{- end }}

@jenting
Copy link
Collaborator

jenting commented Jun 18, 2024

cleanUpCRDs: false

The clean up CRD default is false.

@nonamef
Copy link
Author

nonamef commented Jan 14, 2025

cleanUpCRDs will only disable the cleanup job. I want to keep the CRDs when the helm chart is deleted.
e.g
https://github.com/vmware-tanzu/secrets-manager/blob/51b47cb3e65c196dd88b19382d1089333d2ab4cf/k8s/0.28.1/crds/spire.spiffe.io_clusterstaticentries.yaml#L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants