Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1 surround was working in Version 1.7 only stereo available in 1.8 #22

Open
SpyDaBird opened this issue Jan 14, 2019 · 7 comments
Open

Comments

@SpyDaBird
Copy link

Your add-on is awesome but for me the best feature was 5.1 surround.
In version 1.8 the only option is stereo again. Is this deliberate?
I've reverted back to 1.7 for the surround sound.
Once again though, awesome extension!

@ItsNickBarry
Copy link
Contributor

ItsNickBarry commented Jan 14, 2019

According to the changelog for the Chrome extension, that feature is available through a menu accessed by right-clicking the extension icon. The icon does not appear to exist in the Firefox version, and the new code seems to be Chrome-specific anyway.

@GrabbenD
Copy link

GrabbenD commented Mar 9, 2019

Thanks for providing this plugin @vladikoff.

I reversed to version 1.7 to get 5.1 audio support, everything works wonderfully now. Would there be any reason as to why version 1.8 doesn't show 5.1 audio as a option?

@ItsNickBarry
Copy link
Contributor

@Xriot See my comment above. This extension is a port of the Chrome extension. Someone needs to create a settings menu with the 5.1 audio option for this version of the plugin. I'm not sure how to do that.

@ezickler
Copy link

I turned 5.1 on by default for testing. And i could indeed select 5.1 audio tracks in netflix, but as far as my research goes firefox does not support more than 2 channels of audio. At least not on my linux system. But i might be wrong. Couldn't find that much on the topic.

If one want's to try. just add var use6Channels = true; to get_manifest.js some where before the if(use6Channels) in line 74 or so.

@SpyDaBird
Copy link
Author

SpyDaBird commented Apr 28, 2019

Hey I tested this link on Win 10 with Firefox, https://www2.iis.fraunhofer.de/AAC/multichannel.html Plays AAC Multichannel with Firefox, definitely works goes through each speaker playing audio one at a time - Please note you have to Have 5.1 speaker configuration setup in the windows audio device and I could be wrong but I think aac multi channel is only possible through an HDMI cable, 5.1 configuration in the sound device is not normally necessary for netflix (eg Netflix app its a dolby stream and surround receiver decodes it) The addon seemed to be working with Netflix v1.7 outputting 5.1 as pcm channels through my HDMI cable into my receiver - (Maybe Windows Audio Manager is Mixing the Dolby into PCM?) - My receiver signal info says 5 channel PCM and when I tried it by listening with right ear to rear speakers and left ear to front speakers it sure seemed to be playing independent streams for front and rear but regardless it definitely works on this website - https://www2.iis.fraunhofer.de/AAC/multichannel.html I may be missing something though I'm no expert I suppose Firefox could just be opening a file with surround - Anyway thought I'd throw this info out there to give someone who actually knows what they are doing a head start, like he said, not much info out there about Firefox surround capabilities.

@Multipanda
Copy link

I would also love to get 5.1 back, I actually find that far more important than any increased bitrate, though of course both would be the best. :-)

@progandy
Copy link

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Implement_a_settings_page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants