Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use link_url in Lunr search-result click events, only in production #1571

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Aug 29, 2023

  • Contributes to Track Lunr search-result clicks #1570
  • For search click events:
    • Switches to using event param link_url rather than value to pass the searchResultURL
    • Sets outbound to false
  • Ensures that GA4 search and search-result-click events are emitted only from production built sites

/cc @nate-double-u @harshit-gangal

@chalin chalin force-pushed the chalin-im-srch-click-link-url-2023-08-29 branch from 15fed76 to 32b5170 Compare August 29, 2023 22:44
@chalin chalin mentioned this pull request Aug 29, 2023
3 tasks
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 15fed76
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/64ee74c82683480008d2ddf6
😎 Deploy Preview https://deploy-preview-1571--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 32b5170
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/64ee74ddb0709a0008fe1823
😎 Deploy Preview https://deploy-preview-1571--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@deepthi deepthi merged commit e989ffd into vitessio:prod Sep 12, 2023
5 checks passed
@chalin chalin deleted the chalin-im-srch-click-link-url-2023-08-29 branch November 17, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants