-
Notifications
You must be signed in to change notification settings - Fork 946
Commit
- Loading branch information
There are no files selected for viewing
7 comments
on commit 94d78b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exo me????
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diedsmiling aha.. i was wondering how come my react-native packager suddenly fails :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diedsmiling that got us for a moment there... careful when publishing :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this guys. It was late and I usually don't run sanity checks when releasing code changes made by core contribs. Adding test coverage and static analysis to make sure this doesn't happen in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serves as a great reminder: pin your packages! ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinamps all good, unless you use a package that depends on this package :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the hugs @thebigredgeek happens to all of us :) Thanks for putting in effort to prevent this from happening again. I woke up to Greenkeeper telling me the whole story :) gr2m/selsa#14
Thank you. This caused so much pain!