Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Icon of External Program with Monitor Scaling != 100% #7

Closed
2 tasks done
HeikoKlare opened this issue Jun 28, 2023 · 3 comments
Closed
2 tasks done

Show Icon of External Program with Monitor Scaling != 100% #7

HeikoKlare opened this issue Jun 28, 2023 · 3 comments
Assignees
@HeikoKlare
Labels
Bug A Derivation of Expected Behavior HiDPI A HiDPI-Related Issue or Feature Platform UI Issue for Platform UI SWT Issue for SWT

Comments

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Jun 28, 2023 •
edited
Loading

Current Behavior

With a monitor scaling other than 100% on Windows, files for which external programs (such as the Word logo for .docx files) provide icons do not display that program icon but a default one. On 100% scaling the icon of the external program is shown.

Expected Behavior

The external program icon shall be shown independent of the scaling factor. A patch has already been proposed in eclipse-platform/eclipse.platform.ui#295 and eclipse-platform/eclipse.platform.swt#409. The PR shall be processed to have a fix merged.

Subtasks
@HeikoKlare HeikoKlare converted this from a draft issue Jun 28, 2023
@HeikoKlare HeikoKlare added Platform UI Issue for Platform UI Bug A Derivation of Expected Behavior HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT labels Jun 28, 2023
@HeikoKlare HeikoKlare moved this from 🆕 New to 📋 Backlog in Eclipse Jun 28, 2023
@HeikoKlare HeikoKlare self-assigned this Jul 31, 2023
@HeikoKlare HeikoKlare moved this from 📋 Backlog to 🏗 In progress in Eclipse Jul 31, 2023
This was referenced Jan 15, 2024
Closed
Closed
@HeikoKlare
Copy link
Contributor Author

HeikoKlare commented Jan 24, 2024 •
edited
Loading

Based on subtasks, final fix via:

@HeikoKlare HeikoKlare moved this from 🏗 In Work: Short to 👀 In Review in Eclipse Jan 26, 2024
@HeikoKlare
Copy link
Contributor Author

HeikoKlare commented Jan 31, 2024 •
edited
Loading

Follow-up task to use large icons if available:

@HeikoKlare
Copy link
Contributor Author

Follow-up task closed as currently not reasonably applicable due to consumer behavior. May be revived for #4.

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Eclipse Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeikoKlare HeikoKlare

Labels
Bug A Derivation of Expected Behavior HiDPI A HiDPI-Related Issue or Feature Platform UI Issue for Platform UI SWT Issue for SWT
Projects
Eclipse
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HeikoKlare