-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: install.sh
fails due to 403
#357
Comments
I installed this way instead: curl -fsSL https://github.com/version-fox/vfox/releases/download/v0.5.5/vfox_0.5.5_linux_x86_64.tar.gz \
| tar -xz -C /usr/local/bin --strip-components=1 vfox_0.5.5_linux_x86_64/vfox If you improve your GH release process, this could be simpler.
Then it would look like this: curl -fsSL https://github.com/version-fox/vfox/releases/download/v0.5.5/vfox_linux_x86_64.tar.gz \
| tar -xz -C /usr/local/bin vfox Now only the version tag is in the URL. This allows to also get the curl -fsSL https://github.com/version-fox/vfox/releases/latest/download/vfox_linux_x86_64.tar.gz \
| tar -xz -C /usr/local/bin vfox |
This might because github api has rate limit, |
If you modify your release process, you will not need to use Line 23 in 8968974
Show that after the binary is downloaded and extracted and now you have the version $ vfox --version
vfox version 0.5.5 All of this can be simplified: Lines 46 to 70 in 8968974
Example: sudo mkdir -p /usr/local/bin
if [ $? -ne 0 ]; then
echo 'Failed to create /usr/local/bin directory. Please check your sudo permissions and try again.'
exit 1
fi
local VFOX_LATEST_RELEASE_URL="https://github.com/version-fox/vfox/releases/latest/download/vfox_${OS_TYPE}_${ARCH_TYPE}.tar.gz"
curl -fsSL "${VFOX_LATEST_RELEASE_URL}" | sudo tar -vxz -C /usr/local/bin vfox
if [ $? -ne 0 ]; then
echo 'Failed to extract vfox to /usr/local/bin. Please check your sudo permissions and try again.'
exit 1
fi
echo "$(vfox --version) installed successfully!" No need for To make this work you will need to publish to GH Releases with changes I mentioned:
UPDATE: Sorry, I forgot that you also support |
Version
0.5.5
OS
Linux
Describe the bug
Manual installation instruction fails:
This is due to the
curl
call to get the version (NOTE: This will also fail the earlier check if onlywget
available):vfox/install.sh
Lines 16 to 23 in 8968974
The failure is due to 403 status:
You should not rely on user session to install. I tried to use
vfox
in a container on WSL2.The text was updated successfully, but these errors were encountered: