Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wsgi support #8

Open
ofpiyush opened this issue Mar 13, 2020 · 4 comments
Open

Add wsgi support #8

ofpiyush opened this issue Mar 13, 2020 · 4 comments
Assignees
@ofpiyush

Comments

@ofpiyush
Copy link
Contributor

No description provided.

@ofpiyush ofpiyush added the help wanted Extra attention is needed label Mar 13, 2020
@ofpiyush ofpiyush linked a pull request May 21, 2020 that will close this issue
Wsgi support #17
Closed
@ofpiyush ofpiyush self-assigned this May 21, 2020
@ofpiyush ofpiyush removed the help wanted Extra attention is needed label May 21, 2020
@drish
Copy link

drish commented Apr 13, 2021

hi @ofpiyush !

thanks for working this issue, just wanted to check in and see if there are still any plans on getting this merged ?

@ofpiyush
Copy link
Contributor Author

ofpiyush commented Apr 14, 2021 •
edited
Loading

Hi @drish

At the time, I had stopped because I needed to focus on something else.

When I came back with a fresh perspective, I couldn't find a compelling reason to support WSGI.

Right now, this issue is waiting for that compelling reason.

@drish
Copy link

drish commented Apr 14, 2021

hey @ofpiyush okay, thanks for the update here !

So I think for anybody using a WSGI framework, the option would be to use https://github.com/daroot/protoc-gen-twirp_python_srv, since twirpy only support ASGI frameworks ?

@ofpiyush
Copy link
Contributor Author

Last when I'd talked to Dan, he mentioned that it's still Python2 and he's unlikely to spend effort on the project as he's moved on from the job.

There's a branch with untested wsgi code on this as well based off of Dan's work.

#17

If you can provide a compelling case for WSGI, I'd add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofpiyush ofpiyush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wsgi support verloop/twirpy
2 participants
@ofpiyush @drish